Skip to content

release-24.1: licenseccl: rename usage to environment#130324

Merged
spilchen merged 1 commit intocockroachdb:release-24.1from
spilchen:backport24.1-130161
Sep 9, 2024
Merged

release-24.1: licenseccl: rename usage to environment#130324
spilchen merged 1 commit intocockroachdb:release-24.1from
spilchen:backport24.1-130161

Conversation

@spilchen
Copy link
Contributor

@spilchen spilchen commented Sep 9, 2024 •
edited
Loading

Backport 1/1 commits from #130161.

/cc @cockroachdb/release

This renames the usage field in the license protobuf to environment and deprecates the NonCommercial type.

Epic: CRDB-39988
Informs: CRDB-40069
Release note: none
Release justification: This work is part of the CockroachDB core deprecation.

@spilchen
licenseccl: rename usage to environment
501a4e9 
This renames the usage field in the license protobuf to environment and
deprecates the NonCommercial type.

Epic: CRDB-39988
Closes: CRDB-40069
Release note: none
@spilchen spilchen self-assigned this Sep 9, 2024
@blathers-crl
Copy link

blathers-crl bot commented Sep 9, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 9, 2024
@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Sep 9, 2024

This change is Reviewable

@spilchen spilchen requested a review from mgartner September 9, 2024 13:19
@spilchen spilchen merged commit 63e816e into cockroachdb:release-24.1 Sep 9, 2024
@spilchen spilchen deleted the backport24.1-130161 branch September 9, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mgartner mgartner mgartner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spilchen spilchen

Labels

backport Label PR's that are backports to older release branches v24.1.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spilchen @cockroach-teamcity @mgartner